Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update diff-branch arg saying it supports valid git ref #3345

Conversation

mdedetrich
Copy link
Contributor

@mdedetrich mdedetrich commented Oct 11, 2022

This is just a nice to have PR resulting from the discussion at #3344. When I first read the help output for the cli arg I naively assumed it only worked with local branches, this makes it more clear and should avoid silly questions.

Copy link
Contributor

@tgodzik tgodzik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

@mdedetrich mdedetrich force-pushed the mention-diff-works-on-local-and-remote branch from 3265064 to 1800813 Compare October 11, 2022 13:37
@mdedetrich mdedetrich changed the title Update diff-branch saying it supports both local and remote branches Update diff-branch arg saying it supports valid git ref Oct 11, 2022
@kitbellew
Copy link
Collaborator

@mdedetrich i realized that there are additional confusing aspects (for instance, -diff option should NOT be used along with -diff-branch, as they conflict with each other). let me take this over and send a more comprehensive commit. thanks for your help!

@kitbellew kitbellew closed this Oct 11, 2022
@mdedetrich mdedetrich deleted the mention-diff-works-on-local-and-remote branch October 11, 2022 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants