ScalafmtRunner: add dialectOverride #3300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With dialect overrides to be added subsequently, comparing dialects for reference equality is no longer sufficient.
Also, make a copy in config, to enable subsequent dialect override.
tgodzik
reviewed
Aug 22, 2022
| assert(!config1.runner.getDialect.allowToplevelTerms) | ||
| val config2 = Config | ||
| .fromHoconString(""" | ||
| |runner.dialectOverride.allowToplevelTerms = true |
There was a problem hiding this comment.
Is it only needed for toplevel terms ? Maybe we should have a dialect for scripts instead?
There was a problem hiding this comment.
not at all, this is just a test to show that override works.
while having predefined dialects works well, we have had complaints in the past when some change in scala3 was backported to Scala 2, or kind projector plugin had a new feature, and rather than us trying to keep up, this will allow people to enable features themselves. |
tgodzik
approved these changes
Aug 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.