Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scalafmt: use ammonite parser to handle scripts #3120

Merged
merged 1 commit into from
Feb 11, 2022

Conversation

kitbellew
Copy link
Collaborator

No description provided.

Copy link
Contributor

@tgodzik tgodzik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just one comment.

@@ -74,6 +74,7 @@ import mill._
interp.repositories() =
interp.repositories() ++ Seq(coursier.MavenRepository("https://jitpack.io"))

@
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why the double @ ?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

because there are two @ tokens in the source. old approach was splitting on one or more such tokens as delimiter, and outputting one. new one, obviously, doesn't remove tokens.

this change will not affect existing code. if it had already been handled by scalafmt, then it should have only one already.

@kitbellew kitbellew merged commit 7472d19 into scalameta:master Feb 11, 2022
@kitbellew kitbellew deleted the 3120 branch February 11, 2022 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants