TreeOps: classify Type.Apply only as isCallSite #2749
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgodzik
reviewed
Sep 20, 2021
It was also present in isDefnSite.
kitbellew
commented
Sep 20, 2021
There was a problem hiding this comment.
as you can see from the tests, the only place where this change affects the result is when binpacking is enabled. however, several changes we've merged over the last week (including #2751 an hour ago) have already changed how binpacking behaves, so by comparison this is small potatoes.
| @@ -399,9 +399,9 @@ object TreeOps { | |||
| tree match { | |||
| case _: Decl.Def | _: Defn.Def | _: Defn.Macro | _: Defn.Class | | |||
| _: Defn.Trait | _: Ctor.Secondary | _: Decl.Type | _: Defn.Type | | |||
| _: Type.Apply | _: Type.Param | _: Type.Tuple | _: Defn.Enum | | |||
There was a problem hiding this comment.
take a look at line 440 below. Type.Apply is present in both call site and defn site, but it can't be both.
tgodzik
approved these changes
Sep 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was also present in isDefnSite.