ScalafmtConfig: validate once in the decoder only #2105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are multiple places where a configuration instance is created, and some of them are not really appropriate for validation, such as StyleMap where custom configuration copies are created based on comments in the code, or to support binPack.literalArgumentLists. Therefore, let's just validate the initial configuration in the decoder and not the custom adjustments.
poslegm
reviewed
Jul 20, 2020
scalafmt-core/shared/src/main/scala/org/scalafmt/util/ValidationOps.scala
Show resolved
Hide resolved
poslegm
approved these changes
Jul 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are multiple places where a configuration instance is created, and some of them are not really appropriate for validation, such as
StyleMapwhere custom configuration copies are created based on comments in the code, or to supportbinPack.literalArgumentLists.Therefore, let's just validate the initial configuration in the decoder and not the custom adjustments.
Fixes #2098.