Router: merge classic select chain rule with other #2067
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
poslegm
approved these changes
Jul 5, 2020
| @@ -38,8 +38,8 @@ case class OptimalToken(token: Token, killOnFail: Boolean = false) { | |||
| case class Split( | |||
| modExt: ModExt, | |||
| cost: Int, | |||
| tag: SplitTag = SplitTag.Active, | |||
| activeTag: SplitTag = SplitTag.Active, | |||
| neededTags: Long = SplitTag.Active.mask, | |||
There was a problem hiding this comment.
Not sure how much better the bit mask is than just Set[SplitTag] here and contains instead of (neededTags & splitTag.mask) != 0
There was a problem hiding this comment.
done. i thought i had seen a performance difference earlier but couldn't prove it now.
Also, a few more correct tests, to ensure functionality is preserved.
Remove Active and Ignored explicit tags as no longer needed.
poslegm
approved these changes
Jul 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will apply the same clean indentation logic as for
newlines.source != classic.Requires adding support for multiple activation tags within a split; one was used to apply indent to the first break only, and the new one will be used to reduce cost of a split down the chain after the first break and remove the newline penalization policy consistent with the previous rule; this filtering capability was introduced in #2060.
Fixes #1334. Supersedes #1557.