ScalafmtDynamic: throw once if can't resolve config #2065
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
poslegm
reviewed
Jul 4, 2020
scalafmt-cli/src/main/scala/org/scalafmt/cli/ScalafmtDynamicRunner.scala
Outdated
Show resolved
Hide resolved
scalafmt-cli/src/main/scala/org/scalafmt/cli/ScalafmtDynamicRunner.scala
Outdated
Show resolved
Hide resolved
Remove ScalafmtConfigException and instead change ScalafmtDynamicError to derive from Error, group errors indicating a permanent problem with the config as the ConfigError subtype.
The reflected exception type can't be used directly, so wrap it in the ConfigParseError.
Intellij invokes the createSession method directly and doesn't expect the null value we return there, so throw ConfigError instead. Similarly, in the Runner, change the implementation of MyInstanceSession to verify the config first, so that the config parsing exception is not thrown for every file we are trying to format.
poslegm
approved these changes
Jul 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Intellij invokes the createSession method directly and doesn't expect the null value we return there, so throw ConfigError instead.
Similarly, in the Runner, change the implementation of MyInstanceSession to verify the config first, so that the config parsing exception is not thrown for every file we are trying to format.