Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dockerize #2059

Merged
merged 2 commits into from
Jul 2, 2020
Merged

Dockerize #2059

merged 2 commits into from
Jul 2, 2020

Conversation

gurinderu
Copy link
Contributor

Fixed broken musl build
Add docker publishing

@gurinderu
Copy link
Contributor Author

@poslegm To fix this build you need to add two envs
DOCKER_USERNAME username with permissions for scalameta/scalafmt
DOCKER_PASSWORD access token (you can create a new one here)

- run: bin/build-native-image.sh
env:
CI: true
- uses: actions/upload-artifact@master
with:
name: ${{ matrix.artifact }}
path: scalafmt
dockerize:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will it push new image on every PR?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep, with a custom tag (refs/pull/2/merge | pr-2-merge)

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please configure it as dedicated workflow running only on tags push?

on:
  push:
    branches: [master]
    tags: ["*"]

Image creation on every PR would be redundant

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe it is better to add this flow only for tags?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added condition for tags only.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! I will test it on next release

@poslegm
Copy link
Collaborator

poslegm commented Jul 2, 2020

@gurinderu as far as I understand secrets for Docker already added.

Anyway I have not access to repo's secrets and need to summon @olafurpg here

@olafurpg
Copy link
Member

olafurpg commented Jul 2, 2020

The docker secrets have already been configured but they're only available after merge into master

@poslegm poslegm merged commit e923419 into scalameta:master Jul 2, 2020
@gurinderu
Copy link
Contributor Author

@poslegm hey, How did you release v2.6.2 ? I saw the tag, but didn't see any related actions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants