-
Notifications
You must be signed in to change notification settings - Fork 277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dockerize #2059
Dockerize #2059
Conversation
- run: bin/build-native-image.sh | ||
env: | ||
CI: true | ||
- uses: actions/upload-artifact@master | ||
with: | ||
name: ${{ matrix.artifact }} | ||
path: scalafmt | ||
dockerize: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will it push new image on every PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yep, with a custom tag (refs/pull/2/merge | pr-2-merge)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please configure it as dedicated workflow running only on tags push?
on:
push:
branches: [master]
tags: ["*"]
Image creation on every PR would be redundant
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe it is better to add this flow only for tags?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added condition for tags only.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! I will test it on next release
@gurinderu as far as I understand secrets for Docker already added. Anyway I have not access to repo's secrets and need to summon @olafurpg here |
The docker secrets have already been configured but they're only available after merge into master |
@poslegm hey, How did you release v2.6.2 ? I saw the tag, but didn't see any related actions |
Fixed broken musl build
Add docker publishing