Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove reference to binPack.parentConstructors being a boolean #2049

Merged
merged 1 commit into from
Jun 26, 2020
Merged

Remove reference to binPack.parentConstructors being a boolean #2049

merged 1 commit into from
Jun 26, 2020

Conversation

emma-burrows
Copy link
Contributor

There was a remaining reference to this being a boolean which might confuse users trying to configure this setting. Also thought it could be clearer when this changed and what it was in previous versions.

poslegm
poslegm requested changes Jun 26, 2020
View reviewed changes
Copy link
Collaborator

@poslegm poslegm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Please run yarn format to format markdown because of failed CI.

@emma-burrows
Copy link
Contributor Author

Thank you!

Please run yarn format to format markdown because of failed CI.

Thanks. After reinstalling Node to get yarn format to run, it turned out to be a trailing space at the end of a line. 🤦

@poslegm poslegm merged commit 44b6877 into scalameta:master Jun 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@poslegm poslegm poslegm requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@emma-burrows @poslegm