Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add build with musl libc #2041

Merged
merged 1 commit into from
Jun 23, 2020
Merged

Add build with musl libc #2041

merged 1 commit into from
Jun 23, 2020

Conversation

gurinderu
Copy link
Contributor

No description provided.

@gurinderu gurinderu mentioned this pull request Jun 21, 2020
Closed
@gurinderu
Copy link
Contributor Author

@poslegm Could you review this pr?

@poslegm
Copy link
Collaborator

poslegm commented Jun 22, 2020

Thank you, but can you explain what is purpose for it?

Is it for alpine image mentioned here?

@gurinderu
Copy link
Contributor Author

gurinderu commented Jun 23, 2020 •
edited
Loading

Thank you, but can you explain what is purpose for it?

Is it for alpine image mentioned here?

Yep, it is the one reason, also it is necessary for all Linux systems where musl uses as default glibc )

And I have plans to make a custom step for GitHub actions like https://github.com/openlawteam/scalafmt-ci where the size of an image is critical. Also, it allows using actual scalafmt versions

@poslegm poslegm merged commit a324995 into scalameta:master Jun 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gurinderu @poslegm