Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bugfix: Print stack trace for assertEquals #856

Merged
merged 1 commit into from
Nov 29, 2024
Merged

bugfix: Print stack trace for assertEquals #856

merged 1 commit into from
Nov 29, 2024
+7 −2

Conversation

tgodzik
Copy link
Contributor

@tgodzik tgodzik commented Nov 28, 2024

Not sure why not show the stack trace and it's rather unexpected

Fixes #782

Opinions @valencik @mzuehlke ?

@tgodzik
bugfix: Print stack trace for assertEquals
8181ceb 
Not sure why not show the stack trace and it's rather unexpected

Fixes scalameta#782
@tgodzik tgodzik mentioned this pull request Nov 28, 2024
Open
mzuehlke
mzuehlke approved these changes Nov 28, 2024
View reviewed changes
Copy link
Contributor

@mzuehlke mzuehlke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The 2 test cases you had to adapt didn't even made sense before.
Both didn't contain a stacktrace.

So I think this a good change

@tgodzik tgodzik merged commit 94ffcf5 into scalameta:main Nov 29, 2024
9 checks passed
@tgodzik tgodzik deleted the print-stack branch November 29, 2024 09:23
@AugustNagro
Copy link

Awesome, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mzuehlke mzuehlke mzuehlke approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Full stack trace for assertEquals
3 participants
@tgodzik @AugustNagro @mzuehlke