Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Reenable mima to make sure we don't break compat #776

Merged
merged 1 commit into from
May 8, 2024

Conversation

tgodzik
Copy link
Contributor

@tgodzik tgodzik commented Apr 29, 2024

No description provided.

@tgodzik tgodzik requested a review from valencik April 29, 2024 14:24
@valencik
Copy link
Collaborator

valencik commented May 8, 2024

I'm pretty unfamiliar with how this is normally done.
It looks like we are wiping out all past MIMA exclusions and starting fresh with the 1.0 release?
Is that the common practice?

@tgodzik
Copy link
Contributor Author

tgodzik commented May 8, 2024

I'm pretty unfamiliar with how this is normally done. It looks like we are wiping out all past MIMA exclusions and starting fresh with the 1.0 release? Is that the common practice?

I think so, since we no longer need to compare to 0.x versions, just 1.x. The old exclusions are irrelevant now. We should not have any exclusions aside from added methods/classes on the 1.x series.

Copy link
Contributor

@mzuehlke mzuehlke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think so, since we no longer need to compare to 0.x versions, just 1.x. The old exclusions are irrelevant now. We should not have any exclusions aside from added methods/classes on the 1.x series.

Sounds legit.

@tgodzik tgodzik merged commit 178e378 into scalameta:main May 8, 2024
9 checks passed
@tgodzik tgodzik deleted the reenable-mima branch May 8, 2024 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants