Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Remove deprecated methods before 1.0.0 #773

Merged
merged 1 commit into from
Apr 24, 2024
Merged

chore: Remove deprecated methods before 1.0.0 #773

merged 1 commit into from
Apr 24, 2024

Conversation

tgodzik
Copy link
Contributor

@tgodzik tgodzik commented Apr 24, 2024

I think it's high time to do it since the next option will be at 2.0.0.

After that I will do RC1, bump mima to use it and wait ~2 weeks before releasing 1.0.0?

What do people think?

@tgodzik
chore: Remove deprecated methods before 1.0.0
d3d3b92 
I think it's high time to do it since the next option will be at 2.0.0.
@tgodzik tgodzik requested a review from valencik April 24, 2024 10:34
valencik
valencik approved these changes Apr 24, 2024
View reviewed changes
Copy link
Collaborator

@valencik valencik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am pro removing these deprecated methods, for sure.

Regarding the release schedule, I would really have liked to get the implicit error messages fixed for a 1.0.0 release. But that would require us to wait for Scala 3.3.4

@tgodzik
Copy link
Contributor Author

tgodzik commented Apr 24, 2024

But that would require us to wait for Scala 3.3.4

It's probably 4 weeks away or more if any regression sneaks in :/

@tgodzik tgodzik merged commit 202706f into scalameta:main Apr 24, 2024
9 checks passed
@tgodzik tgodzik deleted the remove-deprecated branch April 24, 2024 15:14
@mzuehlke
Copy link
Contributor

Regarding the release schedule, I would really have liked to get the implicit error messages fixed for a 1.0.0 release. But that would require us to wait for Scala 3.3.4

The PR hasn't even been merged to the LTS branch yet

@mzuehlke
Copy link
Contributor

After that I will do RC1, bump mima to use it and wait ~2 weeks before releasing 1.0.0?

What do people think?

A 1.0 is long overdue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@valencik valencik valencik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tgodzik @mzuehlke @valencik