chore: Update scala native to 0.5.1 #761
Conversation
|
This is blocked by the issue in LTS |
|
Just thinking loud, would we loose anything if we move munit to 3.3.3 and uncomment the failing test ? |
|
At minimum, munit needs to move to 3.3.x to consume the scalacheck artifacts. |
|
Maybe yeah. I will do that in this pr |
| |""".stripMargin | ||
| ) | ||
| } | ||
| if (BuildInfo.scalaVersion != "3.3.3") { |
There was a problem hiding this comment.
Ignored the tests specifically for 3.3.3 so this should not be ignored for the next LTS
There was a problem hiding this comment.
looks good 👍
another possibility would be to have in each of the test as first line
assume(BuildInfo.scalaVersion != "3.3.3")There was a problem hiding this comment.
That's a nicer solution, thanks!
|
I will go ahead and merge this, then release next and hopefully last milestone |
Fixes #760