Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improvement: Add transparent to compileErrors #759

Merged
merged 1 commit into from
Apr 15, 2024

Conversation

tgodzik
Copy link
Contributor

@tgodzik tgodzik commented Apr 15, 2024

This seems to fix issues with #711

@tgodzik
Copy link
Contributor Author

tgodzik commented Apr 15, 2024

Actually it's written to do so in https://scala-lang.org/api/3.4.0/scala/compiletime/testing.html#typeCheckErrors-94d so I think this is legit

confirmed by @jchyb who is our macro wizard

@tgodzik tgodzik marked this pull request as ready for review April 15, 2024 14:40
@tgodzik tgodzik requested a review from valencik April 15, 2024 14:40
Copy link
Collaborator

@valencik valencik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Thanks for the reference link!

An inline definition with a call to typeCheckErrors should be transparent.

@tgodzik tgodzik merged commit ec2ee68 into scalameta:main Apr 15, 2024
9 checks passed
@tgodzik tgodzik deleted the test-transparent branch April 15, 2024 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants