Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move ScalaCheck integration into the toplevel package and add documentation #72

Merged
merged 2 commits into from
Mar 21, 2020

Conversation

gabro
Copy link
Member

@gabro gabro commented Mar 20, 2020

Some docs for #71

Copy link
Member

@olafurpg olafurpg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The docs look great! Just one comment about the package name, we may want to change it and release 0.7.0 🤔

docs/integrations/scalacheck.md Show resolved Hide resolved
docs/integrations/scalacheck.md Outdated Show resolved Hide resolved
@gabro gabro force-pushed the scalacheck-docs branch from cb9ce3b to 687463d Compare March 21, 2020 05:42
@gabro gabro changed the title Add docs for ScalaCheck integration Move ScalaCheck integration into the toplevel package and add documentation Mar 21, 2020
Copy link
Member

@olafurpg olafurpg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@olafurpg olafurpg merged commit f22d9c3 into scalameta:master Mar 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants