Move scalanative.runtime.loop() invocation to correct place
#700
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
armanbilge
commented
Sep 15, 2023
| val reporter = | ||
| new JUnitReporter(eventHandler, loggers, runSettings, taskDef()) | ||
| val notifier: RunNotifier = new MUnitRunNotifier(reporter) | ||
| runner.run(notifier) |
There was a problem hiding this comment.
JS uses runAsync here but actually we want to use run (sync) on Native.
armanbilge
commented
Sep 15, 2023
Comment on lines
+16
to
+19
| def awaitResult[T](awaitable: Awaitable[T]): T = { | ||
| scalanative.runtime.loop() | ||
| Await.result(awaitable, Duration.Inf) | ||
| } |
There was a problem hiding this comment.
valencik
approved these changes
Sep 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#693 had the right idea, but it was invoking
scalanative.runtime.loop()in the wrong place. We should use it toAwait.resulton aFuture.Resolves #695