Relax assertEquals strictness about type equality.
#70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, `assertEquals` only allowed comparing values of the same type. Now, it's OK as long as the second argument is a subtype of the first argument. The reasoning for this change is that it's common that you want to test some generic value like `Option[Int]` obtained from a method we're testing against an expected hardcoded value like `Some[Int]`.
gabro
reviewed
Mar 20, 2020
docs/assertions.md
Outdated
| if one value is a subtype of the other. | ||
| The "expected" value (second argument) must be a subtype of the "obtained" value | ||
| (first argument). It's a type error to compare two values even if one value is a | ||
| subtype of the other. |
There was a problem hiding this comment.
It's not a type error, removed
added 2 commits
March 20, 2020 10:12
Users navigating to the source via IDEs can then learn about the `assertEquals[Any, Any]` escape hatch.
olafurpg
force-pushed
the
subtype
branch
5 times, most recently
from
eb5f1ab to
77f3264
Compare
|
Yay figured out the cryptic windows failures! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following up from an offline conversation with @gabro
Previously,
assertEqualsonly allowed comparing values of the sametype. Now, it's OK as long as the second argument is a subtype of the
first argument. The reasoning for this change is that it's common that
you want to test some generic value like
Option[Int]obtained from amethod we're testing against an expected hardcoded value like
Some[Int].