Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle assume(false) correctly #629

Merged
merged 3 commits into from
Feb 22, 2023
Merged

Conversation

mzuehlke
Copy link
Contributor

@mzuehlke mzuehlke commented Feb 21, 2023

assume(false) gets now handled in the same way as test("description".ignore"). Added tests to cover both ways to skip tests.

Fixes #614


This change leads to the following change in reporting (taken from SkippedFrameworkSuite):

now:

==> success munit.SkippedFrameworkSuite.pass
==> ignored munit.SkippedFrameworkSuite.ignore
==> success munit.SkippedFrameworkSuite.assume(true)
==> skipped munit.SkippedFrameworkSuite.assume(false) - assume it fails

change JVM

 ==> success munit.SkippedFrameworkSuite.pass
-==> skipped munit.SkippedFrameworkSuite.ignore
+==> ignored munit.SkippedFrameworkSuite.ignore
 ==> success munit.SkippedFrameworkSuite.assume(true)
-==> success munit.SkippedFrameworkSuite.assume(false)
+==> skipped munit.SkippedFrameworkSuite.assume(false) - assume it fails

change JS

 ==> success munit.SkippedFrameworkSuite.pass
 ==> ignored munit.SkippedFrameworkSuite.ignore
 ==> success munit.SkippedFrameworkSuite.assume(true)
-==> success munit.SkippedFrameworkSuite.assume(false)
+==> skipped munit.SkippedFrameworkSuite.assume(false) - assume it fails

change native

 ==> success munit.SkippedFrameworkSuite.pass
 ==> ignored munit.SkippedFrameworkSuite.ignore
 ==> success munit.SkippedFrameworkSuite.assume(true)
-==> success munit.SkippedFrameworkSuite.assume(false)
+==> skipped munit.SkippedFrameworkSuite.assume(false) - assume it fails

`assume(false)` gets now handled in the same way as `test("description".ignore")`.
Added tests to cover both ways to skip tests.
@tgodzik
Copy link
Contributor

tgodzik commented Feb 21, 2023

Looks like js and native tests are failing, could you take a look? Seems like they're ignored rather than skipped

@mzuehlke
Copy link
Contributor Author

The result for all the platforms was different. JS was correct and both native and JVM had some issues.
Now they are all identical

Copy link
Member

@olafurpg olafurpg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏻 Thank you for this contribution!

@olafurpg olafurpg merged commit 5858f9e into scalameta:main Feb 22, 2023
@mzuehlke mzuehlke deleted the fix_assume branch February 22, 2023 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Skipped tests reported as passing
3 participants