Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add failSuite() helper to abort the entire test suite #59

Merged
merged 2 commits into from
Feb 17, 2020

Conversation

terjokhin
Copy link
Contributor

@terjokhin terjokhin commented Feb 17, 2020

Fixes #37. Previously, it was possible to abort an individual test case based on a dynamic condition but it was not possible to abort the entire test suite. Now, users can call failSuite("abort test suite!") to prevent subsequent test cases from starting.

@terjokhin terjokhin requested a review from olafurpg February 17, 2020 19:34
Copy link
Member

@olafurpg olafurpg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this contribution! Looks great, only a minor comment

munit/shared/src/main/scala/munit/MUnitRunner.scala Outdated Show resolved Hide resolved
@olafurpg olafurpg changed the title Add failSuite helper. Fixes #37 Add failSuite() helper to abort the entire test suite Feb 17, 2020
@olafurpg
Copy link
Member

PS. I took the liberty to update the PR description with more details. For future PRs, it's good to follow the "previously, ... Now, ... new behavior" structure to help readers understand what changed and why.

@terjokhin
Copy link
Contributor Author

@olafurpg omg, thanks for editing this PR. Next time will do it by myself. 👍

Copy link
Member

@olafurpg olafurpg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@olafurpg olafurpg merged commit cb87436 into scalameta:master Feb 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add failSuite() helper to abort the entire test suite
2 participants