Add support for Scala Native 0.4.0 and cross-publish native for 2.11/2.12/2.13 #298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gabro
force-pushed
the
native-0.4
branch
3 times, most recently
from
fb84b52 to
8199f09
Compare
gabro
commented
Jan 20, 2021
| SettingKey[Boolean]("scalaJSUseMainModuleInitializer").?.value.isDefined | ||
| ) | ||
| val isScalaNative = Def.setting[Boolean]( | ||
| SettingKey[String]("nativeGC").?.value.isDefined |
There was a problem hiding this comment.
nativeGC is now a TaskKey so we can't depend on it to produce a Setting.
Since this was only used to set the unmanagedSourceDirectories below, I've moved the relevant setting down to nativeSettings and jsSettings so we don't need isScalaNative and isScalaJS anymore
| @@ -116,8 +110,7 @@ val sharedJSConfigure: Project => Project = | |||
| _.disablePlugins(MimaPlugin) | |||
| val sharedNativeSettings: List[Def.Setting[_]] = List( | |||
| skipIdeaSettings, | |||
| scalaVersion := scala211, | |||
| crossScalaVersions := List(scala211) | |||
| crossScalaVersions := scala2Versions | |||
olafurpg
approved these changes
Jan 20, 2021
|
Scalacheck has been backpublished, relaunching the CI to see whether it's ok now! |
|
Full steam ahead 🚢 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Blocked by Scalacheck support typelevel/scalacheck#751