Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Scala 3 version to 3.0.0-M1 #241

Merged
merged 1 commit into from
Nov 4, 2020
Merged

Conversation

tgodzik
Copy link
Contributor

@tgodzik tgodzik commented Nov 3, 2020

Connected to #240

Seems we are no longer getting RC versions, so I reverted back to having single stable Dotty version.

@tgodzik tgodzik requested review from gabro and olafurpg November 3, 2020 18:14
@tgodzik tgodzik changed the title Update Scala version for 3.0.0-M1 Update Scala 3 version to 3.0.0-M1 Nov 3, 2020
@tgodzik
Copy link
Contributor Author

tgodzik commented Nov 3, 2020

I guess this will not be that easy after all :( I will take a further look tomorrow, but it seems that we are now printing full names with packages. If anyone wants to fix it today, you can just push to this PR with a fix.

build.sbt Outdated Show resolved Hide resolved
Copy link
Member

@olafurpg olafurpg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to get this in

@mpilquist
Copy link

Is this related? scala/scala3#9716

@tgodzik
Copy link
Contributor Author

tgodzik commented Nov 3, 2020

@mpilquist might be, but that issue was also present in the previous versions, so it shouldn't actually change here 🤔

@mpilquist
Copy link

mpilquist commented Nov 3, 2020

I just noticed this commit in community build -- trying it now: dotty-staging@1e90e97

Update: same failure with this commit applied.

@mpilquist
Copy link

Alright figured this one out -- nothing changed in Dotty w.r.t. showing type prefixes. The bug is that we need to change def isDotty in BaseSuite to account for the version number change.

@gabro
Copy link
Member

gabro commented Nov 3, 2020

Aha, nice catch @mpilquist!

@tgodzik
Copy link
Contributor Author

tgodzik commented Nov 3, 2020

Alright figured this one out -- nothing changed in Dotty w.r.t. showing type prefixes. The bug is that we need to change def isDotty in BaseSuite to account for the version number change.

Thanks! Good catch! I updated the PR and also changed the MacroCompat a bit based on the commit you mentioned before.

@tgodzik
Copy link
Contributor Author

tgodzik commented Nov 3, 2020

I will merge and release first thing tomorrow (just in case there is an issue) if no one objects.

@mpilquist
Copy link

Looks good to me. Once munit publishes, we'll be able to start building the various Typelevel libraries. The sooner the better but if you want to wait until tomorrow, that's great. :)

Copy link
Member

@gabro gabro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👏

@djspiewak
Copy link

Seems we are no longer getting RC versions, so I reverted back to having single stable Dotty version.

I definitely object. It's very very difficult for downstream projects to juggle incompatibilities as the ecosystem updates. Maintaining builds for the two most recent Dotty releases (whenever possible) makes this significantly easier since it allows libraries to take the upgrade in chunks, particularly if and when munit itself makes changes. Publishing for the latest two dotty releases ensures that users are able to split the upgrade pain into two steps: upgrade munit, then upgrade dotty.

Meanwhile, from the perspective of a library maintainer, not dropping the previous Dotty release is usually completely painless. Sometimes it has to be done, and particularly with ScalaJS shenanigans I can see merit to dropping 0.27.0-RC1, but I would strongly recommend that publication be for Mn and M(n-1) from this point forward. We're about to go through the most convoluted and painful cross-publication coordination effort in Scala's history; the least we can do is try to learn from what has made all of the other (otherwise simpler) migrations difficult at times.

@tgodzik
Copy link
Contributor Author

tgodzik commented Nov 3, 2020

Seems we are no longer getting RC versions, so I reverted back to having single stable Dotty version.

I definitely object. It's very very difficult for downstream projects to juggle incompatibilities as the ecosystem updates. Maintaining builds for the two most recent Dotty releases (whenever possible) makes this significantly easier since it allows libraries to take the upgrade in chunks, particularly if and when munit itself makes changes. Publishing for the latest two dotty releases ensures that users are able to split the upgrade pain into two steps: upgrade munit, then upgrade dotty.

Meanwhile, from the perspective of a library maintainer, not dropping the previous Dotty release is usually completely painless. Sometimes it has to be done, and particularly with ScalaJS shenanigans I can see merit to dropping 0.27.0-RC1, but I would strongly recommend that publication be for Mn and M(n-1) from this point forward. We're about to go through the most convoluted and painful cross-publication coordination effort in Scala's history; the least we can do is try to learn from what has made all of the other (otherwise simpler) migrations difficult at times.

I can add back 0.27.0-RC1 for sure, might have rushed with dropping it.

@olafurpg
Copy link
Member

olafurpg commented Nov 3, 2020

@tgodzik feel free to merge and release when this PR is ready!

@tgodzik
Copy link
Contributor Author

tgodzik commented Nov 4, 2020

@djspiewak I added back the 0.27.0-RC1 version. If everything runs ok, I will merge and release it if no one objects?

@tgodzik tgodzik merged commit a81bc6d into scalameta:master Nov 4, 2020
@tgodzik tgodzik deleted the update-dotty branch November 4, 2020 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants