-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Scala 3 version to 3.0.0-M1 #241
Conversation
I guess this will not be that easy after all :( I will take a further look tomorrow, but it seems that we are now printing full names with packages. If anyone wants to fix it today, you can just push to this PR with a fix. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good to get this in
Is this related? scala/scala3#9716 |
@mpilquist might be, but that issue was also present in the previous versions, so it shouldn't actually change here 🤔 |
I just noticed this commit in community build -- trying it now: dotty-staging@1e90e97 Update: same failure with this commit applied. |
Alright figured this one out -- nothing changed in Dotty w.r.t. showing type prefixes. The bug is that we need to change |
Aha, nice catch @mpilquist! |
Thanks! Good catch! I updated the PR and also changed the MacroCompat a bit based on the commit you mentioned before. |
I will merge and release first thing tomorrow (just in case there is an issue) if no one objects. |
Looks good to me. Once munit publishes, we'll be able to start building the various Typelevel libraries. The sooner the better but if you want to wait until tomorrow, that's great. :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice 👏
I definitely object. It's very very difficult for downstream projects to juggle incompatibilities as the ecosystem updates. Maintaining builds for the two most recent Dotty releases (whenever possible) makes this significantly easier since it allows libraries to take the upgrade in chunks, particularly if and when munit itself makes changes. Publishing for the latest two dotty releases ensures that users are able to split the upgrade pain into two steps: upgrade munit, then upgrade dotty. Meanwhile, from the perspective of a library maintainer, not dropping the previous Dotty release is usually completely painless. Sometimes it has to be done, and particularly with ScalaJS shenanigans I can see merit to dropping 0.27.0-RC1, but I would strongly recommend that publication be for |
I can add back |
@tgodzik feel free to merge and release when this PR is ready! |
@djspiewak I added back the |
Connected to #240
Seems we are no longer getting RC versions, so I reverted back to having single stable Dotty version.