doc: flesh out the conversion to ScalaTest docs a good deal #166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Link back to relevant information elsewhere in the docs * Add tactical tips * Explain differences in `build.sbt` between MUnit and ScalaTest * Add some structure to the now-copious information Hopefully this will encourage adoption!
|
Thank you for this pr! It may take a couple weeks for me to look into this since I’ll be away on holidays |
|
@olafurpg Thanks for letting me know. I've taken these notes now while I'm fresh, so I'm in no rush. Enjoy your holidays! |
olafurpg
approved these changes
Aug 31, 2020
There was a problem hiding this comment.
This documentation is fantastic. Very clear and easy to follow along. Thank you for this contribution! I'm gonna merge even if the CI is red, I can't restart the jobs for some reason but I don't see a reason why the build would fail since there are no code changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
build.sbtbetween MUnit and ScalaTestHopefully this will encourage adoption!
Note that I was not able to test locally; I could not get the build running. I want to to test that the headers looked okay, and that the links worked. However, I was fairly careful about putting in the links, so I expect it should be fine. If you are at all nervous about it, you may want to render it and see if it is okay.