Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

intermittent test failure (TimeoutSuite) #31

Closed
SethTisue opened this issue Jan 29, 2020 · 4 comments
Closed

intermittent test failure (TimeoutSuite) #31

SethTisue opened this issue Jan 29, 2020 · 4 comments

Comments

@SethTisue
Copy link
Contributor

not sure how often it happens, but I did see it once already: https://scala-ci.typesafe.com/job/scala-2.12.x-jdk14-integrate-community-build/699/artifact/logs/munit-build.log

[munit] �[91m==> X �[0m�[91mmunit.TimeoutSuite�[0m.�[91mfast�[0m  �[90m0.025s�[0m java.util.concurrent.TimeoutException: Futures timed out after [10 milliseconds]
@olafurpg
Copy link
Member

Thank you for reporting! We can increase the timeout for that test. We have already run this test 84 times in our GitHub Actions CI without any flaky failures

Screenshot 2020-01-29 at 13 17 47

https://scalameta.org/munit/docs/reports.html

olafurpg pushed a commit to olafurpg/munit that referenced this issue Jan 29, 2020
@olafurpg
Copy link
Member

I opened #32 increasing the timeout from 10ms to 100ms

olafurpg added a commit that referenced this issue Jan 29, 2020
Increase timeout for TimeoutSuite, fixes #31
@olafurpg
Copy link
Member

Please let me know if the problem persists. I'm not sure if there is a better way to test functionality like this, async code is generally quite tricky to test

@olafurpg olafurpg reopened this Jan 29, 2020
SethTisue added a commit to scala/community-build that referenced this issue Jan 29, 2020
@SethTisue
Copy link
Contributor Author

scala/community-build@2b61ffb pulls in the fix (and I also merged it forward onto 2.12.x and 2.13.x)

if I ever see the test fail again, I'll report it here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants