Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Timeout for Future-free test #292

Closed
OlivierBlanvillain opened this issue Jan 15, 2021 · 1 comment · Fixed by #435
Closed

Timeout for Future-free test #292

OlivierBlanvillain opened this issue Jan 15, 2021 · 1 comment · Fixed by #435
Milestone
MUnit v1.0

Comments

@OlivierBlanvillain
Copy link
Contributor

OlivierBlanvillain commented Jan 15, 2021 •
edited
Loading

Tests with an override val munitTimeout setting only time out when the test returns a Future. I think the setting name is really misleading... I propose to either:

  1. Rename the setting to munitFutureTimeout or munitAyncTestTimeout
  2. Make the setting effective for Future-free tests
@olafurpg olafurpg added this to the MUnit v1.0 milestone Oct 16, 2021
olafurpg added a commit to olafurpg/munit that referenced this issue Oct 16, 2021
@olafurpg
Respect munitTimeout for non-Future tests
aedf93f 
Fixes scalameta#292

Previously, the `munitTimeout` value was only used for async tests. Now,
  this value is respected for non-async tests as well.
olafurpg added a commit to olafurpg/munit that referenced this issue Oct 16, 2021
@olafurpg
Respect munitTimeout for non-Future tests
9a73866 
Fixes scalameta#292

Previously, the `munitTimeout` value was only used for async tests. Now,
  this value is respected for non-async tests as well.
olafurpg added a commit to olafurpg/munit that referenced this issue Oct 16, 2021
@olafurpg
Respect munitTimeout for non-Future tests
6297eec 
Fixes scalameta#292

Previously, the `munitTimeout` value was only used for async tests. Now,
  this value is respected for non-async tests as well.
olafurpg added a commit to olafurpg/munit that referenced this issue Oct 16, 2021
@olafurpg
Respect munitTimeout for non-Future tests
e81eba2 
Fixes scalameta#292

Previously, the `munitTimeout` value was only used for async tests. Now,
  this value is respected for non-async tests as well.
olafurpg added a commit to olafurpg/munit that referenced this issue Oct 16, 2021
@olafurpg
Respect munitTimeout for non-Future tests
250484b 
Fixes scalameta#292

Previously, the `munitTimeout` value was only used for async tests. Now,
  this value is respected for non-async tests as well.
@olafurpg olafurpg mentioned this issue Oct 16, 2021
Merged
@olafurpg
Copy link
Member

Thank you for reporting! This is a good idea, and it's easy to implement after the recently added support for async fixtures (which required refactoring how we evaluate test bodies). I opened a PR #435 making the munitTimeout setting apply to non-async tests. This may break some non-async tests that are slow to run.

@mbovel mbovel mentioned this issue Jan 4, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
MUnit v1.0
Development

Successfully merging a pull request may close this issue.

Respect munitTimeout for non-Future tests olafurpg/munit
2 participants
@OlivierBlanvillain @olafurpg