Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When an async test times out, any fixtures used in the tests are not torn down #285

Closed
bilal-fazlani opened this issue Jan 10, 2021 · 1 comment · Fixed by #436
Closed

When an async test times out, any fixtures used in the tests are not torn down #285

bilal-fazlani opened this issue Jan 10, 2021 · 1 comment · Fixed by #436
Milestone
MUnit v1.0

Comments

@bilal-fazlani
Copy link

No description provided.

@bilal-fazlani bilal-fazlani changed the title When as async test times out, any fixtures used in the tests are not torn down When an async test times out, any fixtures used in the tests are not torn down Jan 10, 2021
@olafurpg olafurpg added this to the MUnit v1.0 milestone Oct 16, 2021
olafurpg added a commit to olafurpg/munit that referenced this issue Oct 16, 2021
@olafurpg
Add reproduction for scalameta#285
4419ea1 
The bug appears to be fixed with the recent changes to async fixtures.
olafurpg added a commit to olafurpg/munit that referenced this issue Oct 16, 2021
@olafurpg
Add reproduction for scalameta#285
b93ca32 
The bug appears to be fixed with the recent changes to async fixtures.
olafurpg added a commit to olafurpg/munit that referenced this issue Oct 16, 2021
@olafurpg
Add reproduction for scalameta#285
8804708 
The bug appears to be fixed with the recent changes to async fixtures.
@olafurpg olafurpg mentioned this issue Oct 16, 2021
Merged
@olafurpg
Copy link
Member

Thank you for reporting! I'm unable to reproduce with the latest version of MUnit (v1.0.0-M1). I opened a PR reproducing the case and the fixture gets torn down on timeout. The PR #430 changed how the timeout is implemented which probably fixed this bug.

olafurpg added a commit to olafurpg/munit that referenced this issue Oct 16, 2021
@olafurpg
Add reproduction for scalameta#285
b462569 
The bug appears to be fixed with the recent changes to async fixtures.
olafurpg added a commit to olafurpg/munit that referenced this issue Oct 16, 2021
@olafurpg
Add reproduction for scalameta#285
189cfb4 
The bug appears to be fixed with the recent changes to async fixtures.
olafurpg added a commit that referenced this issue Oct 16, 2021
@olafurpg
Add reproduction for #285 (#436)
36aeb75
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
MUnit v1.0
Development

Successfully merging a pull request may close this issue.

Add reproduction for #285 olafurpg/munit
2 participants
@olafurpg @bilal-fazlani