Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bugfix: Extension completions in interpolated strings #6073

Merged
merged 1 commit into from
Feb 2, 2024
Merged

bugfix: Extension completions in interpolated strings #6073

merged 1 commit into from
Feb 2, 2024

Conversation

jkciesluk
Copy link
Member

fixes #6067

@jkciesluk jkciesluk requested a review from kasiaMarek February 1, 2024 13:33
tgodzik
tgodzik approved these changes Feb 1, 2024
View reviewed changes
Copy link
Contributor

@tgodzik tgodzik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jkciesluk jkciesluk merged commit ae1301e into scalameta:main Feb 2, 2024
27 checks passed
@jkciesluk jkciesluk deleted the i6067 branch February 2, 2024 10:32
@kasiaMarek kasiaMarek mentioned this pull request Feb 5, 2024
Merged
tgodzik added a commit to scala/scala3 that referenced this pull request Feb 5, 2024
@tgodzik
Backport pc changes from metals (#19617)
5c628d9 
metals backport:
scalameta/metals#6075
scalameta/metals#6073
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tgodzik tgodzik tgodzik approved these changes

@kasiaMarek kasiaMarek Awaiting requested review from kasiaMarek

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Scala 3 extension completion in interpolated string is incorrect
3 participants
@jkciesluk @tgodzik @kasiaMarek