refactor: ensure we're testing the connection with Mill #4642
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When I opened com-lihaoyi/mill#2123 it made me wonder why we didn't hit on this in our tests, but then I realized we were actually never testing the initialization with Mill server. This adds some more tests to ensure we're not only testing the generation of the BSP config file, but also connection to the build server.
tgodzik
requested changes
Nov 15, 2022
tgodzik
approved these changes
Nov 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I opened com-lihaoyi/mill#2123 it made me wonder why we didn't hit on this in our tests, but then I realized we were actually never testing the initialization with Mill server. This adds some more tests to ensure we're not only testing the generation of the BSP config file, but also connection to the build server.
NOTE Marking this as a draft for now because it's expected that 0.10.9 (which is our default right now) will fail. There should be a new release of millw soon with a fix, which should fix this. When that happens I'll add another commit to this adding in the new millw and showing that the tests all pass.