Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #405: Completely overhaul erasure of value classes. #408

Merged
merged 1 commit into from
Dec 1, 2023

Conversation

sjrd
Copy link
Contributor

@sjrd sjrd commented Nov 30, 2023

Including when they contain arrays or are contained in arrays.

@sjrd sjrd requested a review from adpi2 November 30, 2023 14:43
@sjrd sjrd force-pushed the fix-parametric-value-class-erasure branch 2 times, most recently from 6d5ea6a to 0fa4d14 Compare November 30, 2023 14:46
Including when they contain arrays or are contained in arrays.
@sjrd sjrd force-pushed the fix-parametric-value-class-erasure branch from 0fa4d14 to 912dabe Compare November 30, 2023 17:00
Copy link
Member

@adpi2 adpi2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on the binary decoder. It works well.

@sjrd sjrd merged commit 06ffbf0 into scalacenter:main Dec 1, 2023
4 checks passed
@sjrd sjrd deleted the fix-parametric-value-class-erasure branch December 1, 2023 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants