Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework migrate-libs #424

Merged
merged 2 commits into from
Aug 28, 2023
Merged

Rework migrate-libs #424

merged 2 commits into from
Aug 28, 2023

Conversation

adpi2
Copy link
Member

@adpi2 adpi2 commented Aug 27, 2023

The main goal of this PR is to improve the output message of the migrate-libs command to make it less verbose and more readable. While doing so I also reworked the internal implementation of library migration.

I am mostly interested in a review of the output message.

Before the PR:
image

After the PR:
image

@adpi2 adpi2 requested a review from sjrd August 27, 2023 12:34
@adpi2 adpi2 force-pushed the rework-migrate-libs branch 2 times, most recently from ef6ac75 to 3ba9f7d Compare August 28, 2023 07:05
Copy link
Contributor

@sjrd sjrd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@adpi2 adpi2 merged commit 2fdd43b into scalacenter:main Aug 28, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants