prevent failure on sbt init when JGit finds a .git with no commit #141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bjaglin
commented
Jul 6, 2020
Comment on lines
20
to
26
| test("directory with no commits") { | ||
| val fs = new Fs() | ||
| new Git(fs.workingDirectory) // git init | ||
| val jgit = new JGitCompletion(fs.workingDirectory) | ||
| assert(jgit.last20Commits == Nil) | ||
| } |
There was a problem hiding this comment.
that's the one reproducing scalacenter/scalafix#1196 (comment) (the other tests pass on master, while this one fails)
2ca68e4 exposed failure to lookup commits during sbt initialization, while it would only happen on `scalafix` invocation earlier.
olafurpg
approved these changes
Jul 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref scalacenter/scalafix#1196
Regression detected between 0.9.17 & 0.9.18, introduced by #126
2ca68e4 exposed the failure to lookup commits during sbt initialization, while it would only happen on
scalafixinvocation earlier.While looking at that, I initially thought 2ca68e4 changed the behavior by eagerly fetching the last commits into a setting, but that lookup is memoized in a lazy val anyway, so a
sbt reloadis required before or after 2ca68e4 to get an up-to-date list of commits.