-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release 24.12.0 #8264
Release 24.12.0 #8264
Conversation
📝 Walkthrough📝 WalkthroughWalkthroughThe pull request introduces version 24.12.0 of WEBKNOSSOS, featuring enhancements in remote URI handling, asynchronous image file reading, improved error messaging, and a shift in the Terms of Service acceptance process. It also removes bounding box restrictions for super users and enhances logging for dataset operations. Several bugs have been fixed, including performance issues and incorrect segment color updates. Additionally, the integration of Google Analytics has been completely removed, indicating a change in tracking strategy. Changes
Possibly related PRs
Suggested labels
Suggested reviewers
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (3)
🚧 Files skipped from review as they are similar to previous changes (3)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (1)
CHANGELOG.released.md (1)
13-31
: Consider adding bullet points for better readabilityThe Highlights section would be more readable if each highlight was formatted as a bullet point using
-
or*
.### Highlights - When exploring remote URIs pasted from Neuroglancer, the format prefixes like `precomputed://` are now ignored, so users don't have to remove them. - Reading image files on datastore filesystem is now done asynchronously. - Terms of Service for Webknossos are now accepted at registration, not afterward.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (4)
CHANGELOG.released.md
(1 hunks)CHANGELOG.unreleased.md
(1 hunks)MIGRATIONS.released.md
(2 hunks)MIGRATIONS.unreleased.md
(1 hunks)
✅ Files skipped from review due to trivial changes (1)
- MIGRATIONS.unreleased.md
🔇 Additional comments (4)
CHANGELOG.unreleased.md (1)
11-11
: LGTM: Version reference correctly updated.
The changelog template has been properly reset for future unreleased changes, with the version reference correctly pointing to 24.12.0.
MIGRATIONS.released.md (1)
9-13
: LGTM: Migration steps properly documented.
The migration guide correctly documents:
- The deprecation of
googleAnalytics.trackingId
config option - Links to relevant PR Remove Google Analytics #8201
- Proper version comparison links
Let's verify if there are any remaining references to the deprecated config:
CHANGELOG.released.md (2)
10-11
: LGTM!
The version header and commits link follow the standard changelog format.
Line range hint 33-48
: LGTM!
The Added, Changed and Fixed sections follow the standard changelog format with proper bullet points and clear descriptions.
Also applies to: 50-52, 54-58
So, renamable datasets will come in 25.01.0? |
Yes, see slack discussion. |
Release is built on 5d3d66d.