Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update default security.txt for 2025 #8192

Merged
merged 1 commit into from
Nov 13, 2024
Merged

Conversation

frcroth
Copy link
Member

@frcroth frcroth commented Nov 13, 2024

Current info is stale.

https://www.rfc-editor.org/rfc/rfc9116#name-expires

Should be updated regularly

Summary by CodeRabbit

  • New Features

    • Extended expiration date for security settings, enhancing long-term security measures.
    • Introduced a new token authenticator configuration for improved session management.
  • Bug Fixes

    • Standardized timeout values for requests, idle connections, and overall connection stability.
  • Chores

    • Maintained existing configurations while ensuring consistency across various components.

@frcroth frcroth requested a review from fm3 November 13, 2024 12:44
@frcroth frcroth self-assigned this Nov 13, 2024
Copy link
Contributor

coderabbitai bot commented Nov 13, 2024

Walkthrough

The pull request introduces modifications to the conf/application.conf configuration file, focusing on security settings, timeout configurations, and feature adjustments. Key updates include an extension of the expiration date for the securityTxt content, the addition of a tokenAuthenticator configuration with a specified authenticatorIdleTimeout, and standardized timeout values across the ws section. Other sections, such as webKnossos and features, retain their existing configurations with minor adjustments.

Changes

File Change Summary
conf/application.conf - Updated securityTxt.content.Expires from "2024-07-03T10:00:00.000Z" to "2025-07-03T10:00:00.000Z".
- Added silhouette.tokenAuthenticator.authenticatorIdleTimeout and authenticatorExpiry set to "23000 days".
- Standardized timeout values for ws section: request, idle, and connection set to 2 hours.
- Retained existing configurations in webKnossos and features sections without changes.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant Application
    participant Security
    participant WS

    User->>Application: Request access
    Application->>Security: Validate credentials
    Security-->>Application: Return validation result
    Application->>WS: Set timeout configurations
    WS-->>Application: Confirm timeouts set
    Application-->>User: Access granted
Loading

🐰 "In the garden of code, changes bloom bright,
Security's shield shines, a marvelous sight.
Timeouts aligned, like stars in the sky,
With updates so sweet, let our features fly!
Hopping through settings, with joy we embrace,
In the world of our app, we find our place!" 🌼


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Outside diff range and nitpick comments (1)
conf/application.conf (1)

128-128: LGTM! The expiration date update complies with RFC 9116.

The new expiration date of July 3rd, 2025 is valid as it's less than one year in the future, following the requirements in RFC 9116.

Consider setting up a reminder (e.g., GitHub issue with a deadline) to update this again before expiration.

Would you like me to create a GitHub issue to track the next security.txt update?

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between 3a18852 and 158a86a.

📒 Files selected for processing (1)
  • conf/application.conf (1 hunks)

@frcroth frcroth merged commit 1ec9b19 into master Nov 13, 2024
3 checks passed
@frcroth frcroth deleted the update-securitytxt-2024 branch November 13, 2024 13:31
@fm3
Copy link
Member

fm3 commented Nov 13, 2024

Should we create a yearly slack reminder?

@frcroth
Copy link
Member Author

frcroth commented Nov 13, 2024

Should we create a yearly slack reminder?

Good idea, did this now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants