Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to delete bbox even if there is no visible segmentation layer #8164

Merged
merged 3 commits into from
Nov 4, 2024

Conversation

knollengewaechs
Copy link
Contributor

@knollengewaechs knollengewaechs commented Nov 4, 2024

URL of deployed dev instance (used for testing):

  • https://___.webknossos.xyz

Steps to test:

  • Open an annotation with a segmentation layer
  • (add and) remove some bounding boxes, save, reload
  • do the same without a visible segmentation layer
  • both should work
  • this should not be possible in a read-only annotation

Issues:


(Please delete unneeded items, merge only when none are left open)

Summary by CodeRabbit

  • New Features

    • Simplified logic for the delete action in the context menu, making it easier to enable or disable based on the disabled state.
    • Added the ability to add metadata to annotations for Trees and Segments.
    • Introduced a summary row in the time tracking overview.
    • Enhanced slider functionality for value changes and resets.
    • Improved search functionality for unnamed segments.
    • Increased loading speed for precomputed meshes.
    • Added a button in the search popover for selecting all matching non-group results.
  • Bug Fixes

    • Improved reliability of the delete option by removing unnecessary dependencies on other states.
    • Resolved issues with dataset uploads and bbox export menu item.
    • Fixed bugs related to sharing tokens and annotation downloads.
  • Documentation

    • Minor updates to comments for clarity.

@knollengewaechs knollengewaechs self-assigned this Nov 4, 2024
Copy link
Contributor

coderabbitai bot commented Nov 4, 2024

Walkthrough

The changes in this pull request focus on the UserBoundingBoxInput class within the setting_input_views.tsx file. The primary modification involves the logic for enabling the delete action in the context menu, simplifying the condition from a check on visibleSegmentationLayer and disabled to solely relying on the disabled state. Additionally, minor formatting and comment adjustments were made, but the overall functionality and structure of the component remain unchanged. The changelog has also been updated to reflect new features, changes, and bug fixes across the application.

Changes

File Path Change Summary
frontend/javascripts/oxalis/view/components/setting_input_views.tsx Modified the delete action logic in UserBoundingBoxInput to only check if disabled is false. Adjusted comments and formatting.
CHANGELOG.unreleased.md Updated to include new features, changes, and bug fixes, including independent deletion of bounding boxes.

Possibly related PRs

  • Fix bbox export via bbox menu #8152: The changes in this PR involve the export functionality of bounding boxes, which is related to the delete functionality in the main PR, as both involve managing bounding box actions within the application.

Suggested labels

bug, frontend

Suggested reviewers

  • normanrz

Poem

In the code where boxes dwell,
A delete button rang its bell.
No longer bound by layers seen,
Just a simple state, clean and keen.
Hooray for changes, bright and spry,
A rabbit hops and waves goodbye! 🐇✨


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Member

@hotzenklotz hotzenklotz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants