Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automatically use user token when sharing token is not sufficient for a request #8139
Automatically use user token when sharing token is not sufficient for a request #8139
Changes from 8 commits
ffda9f1
5e322f4
ac1a898
51667e8
6ec4428
0cecca2
8d9d80c
e574d8a
273c233
9438530
3410ad7
034fe9e
1a3675f
69ec689
1660fa7
24e354c
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is a technical detail that we shouldn't bother users with. I would replace the
Toast
with aconsole.log()
for debugging purposes but not actively show it in the UI.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So just hiding the error toast is enough you think? My thought was to somewhat inform the user that saving / or some other request worked on second try.
Therefore, maybe a toast with a message like "Request succeeded on upon retry" or something similar?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But yeah, I agree that the technical details are definitely too much in my toast message