OME-Zarr NGFF v0.5 dataset exploration #8122
Conversation
frcroth
changed the title
...-datastore/app/com/scalableminds/webknossos/datastore/explore/ExploreLocalLayerService.scala
Show resolved
Hide resolved
| Vec3Double(xFactors.product, yFactors.product, zFactors.product) | ||
| } | ||
|
|
||
| protected def getShape(dataset: NgffDataset, path: VaultPath): Fox[Array[Int]] = ??? |
There was a problem hiding this comment.
can the = ??? be removed? Then the compiler should check that all classes implementing the trait implement this.
| nameFromPath = guessNameFromPath(remotePath) | ||
| name = multiscale.name.getOrElse(nameFromPath) | ||
| layerTuples <- Fox.serialCombined((0 until channelCount).toList)({ channelIndex: Int => | ||
| for { |
There was a problem hiding this comment.
some of these functions have gotten pretty big. Maybe it would make sense to extract some parts into separate named functions? Maybe the nested for comprehensions are a good candidate.
| additionalAxes = Some(additionalAxes), | ||
| defaultViewConfiguration = Some(viewConfig), | ||
| ) | ||
| } yield (layer, VoxelSize(voxelSizeFactor, unifiedAxisUnit)) |
There was a problem hiding this comment.
looks like there is still quite a bit of duplication between 0_5 and 0_4. I wonder if some more code could be extracted into functions to be moved into the new trait? But I might have overlooked some subtle differences.
There was a problem hiding this comment.
zarrMagFromNgffDataset needs to remain duplicated because it uses getZarrHeader, which returns differnt headers (case classes, so I don't think we can use a trait here).
But I moved a liitle more.
| fileAsString <- tryo(new String(fileBytes, StandardCharsets.UTF_8)).toFox ?~> "dataset.explore.failed.readFile" | ||
| parsed <- JsonHelper.parseAndValidateJson[T](fileAsString) | ||
| } yield parsed | ||
| path.parseAsJson[T] |
There was a problem hiding this comment.
What do you mean by that?
There was a problem hiding this comment.
The function is a single line now, so I would suggest deleting the function and replacing all usages of parseJsonFromPath(path) directly by path.parseAsJson
URL of deployed dev instance (used for testing):
Since on GitHub the diff is very big: I renamed the NgffExplorer to NgffV0_4Explorer, created NgffV0_5Explorer, extracted common behavior to the NgffExplorationUtils.
Steps to test:
TODOs:
Issues:
(Please delete unneeded items, merge only when none are left open)