Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix registering segments in bbox for segmentations with missing mag1 #8009

Merged
merged 3 commits into from
Aug 19, 2024

Conversation

philippotto
Copy link
Member

@philippotto philippotto commented Aug 19, 2024

URL of deployed dev instance (used for testing):

  • https://___.webknossos.xyz

Steps to test:

  • create a volume annotation without mag1 with fallback layer
  • create a bbox
  • use register all segments feature
  • saving should work

Issues:


(Please delete unneeded items, merge only when none are left open)

@philippotto philippotto self-assigned this Aug 19, 2024
Copy link
Contributor

@MichaelBuessemeyer MichaelBuessemeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, testing went well and good looks good. Thanks for the fast fix :)

Comment on lines +691 to +693
for (let z = min[2]; z < max[2]; z += dz) {
for (let y = min[1]; y < max[1]; y += dy) {
for (let x = min[0]; x < max[0]; x += dx) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@philippotto philippotto merged commit 4f7e2a4 into master Aug 19, 2024
2 checks passed
@philippotto philippotto deleted the fix-register-segments-in-bbox-mag2 branch August 19, 2024 11:54
knollengewaechs pushed a commit that referenced this pull request Sep 2, 2024
…8009)

* fix registering segments in bbox for segmentations with missing mag1

* update changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants