add links for skipped tasks in voxelytics workflow reports #8006
Conversation
| FROM webknossos.voxelytics_artifacts a | ||
| JOIN latest_complete_tasks t ON t._id = a._task | ||
| """.as[(String, String, String, String, Long, Long, String, String, String)]) | ||
| LEFT JOIN ( -- when the task is skipped, the artifact from the producing task run is joined for linking |
There was a problem hiding this comment.
please add the discussed distinct constraint to the schema, and a comment here explaining how the fanout effect is prevented (joining at most one item, due to the distinct constraint)
There was a problem hiding this comment.
Works for me and backend looks good :)
Leaving final approval for @daniel-wer
Maybe a tooltip on the links to the “foreign workflow” would be nice, but not super important
There was a problem hiding this comment.
Spectacular 🎉 This already made my week and is going to be very helpful in the future :)
Should I retest this somehow or do you think it's fine to test this in prod using the real-world reports?
How does this affect the file size shown next to a workflow in the workflow list? Same for the "Show Disk Usage of Artifacts" modal that can be displayed from within a report? I don't have a strong opinion on which way it should be counted, but I'd like to at least document the current behavior in this PR.
The storage display in the workflow list is not affected by this change. I think that makes sense. Only artifacts that are produced by that particular workflow are counted. The "Show Disk Usage of Artifacts" would show include the foreign artifacts. Should I filter them out for consistency? |
I'd say it's ok as it is |
* add links for skipped tasks in voxelytics workflow reports * changelog * comments * styling * add evolution and comment --------- Co-authored-by: Florian M <[email protected]>
This PR (finally) adds links for skipped tasks in the workflow reports to the workflows/runs where the artifacts were produced. The artifact information is also shown inline.
Steps to test:
Issues: