Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Text in Upload Dataset View #7996

Merged
merged 19 commits into from
Sep 4, 2024
Merged

Conversation

knollengewaechs
Copy link
Contributor

@knollengewaechs knollengewaechs commented Aug 15, 2024

https://updateuploaddstext.webknossos.xyz/

Steps to test:

  • Click "upload dataset"
  • Toggle the options recommendWkorgInstance and isDatasetConversionDisabled to check that all combinations look nice
  • Check links

To do

  • fix tests: update snapshot misc.e2e.js.snap

Issues:


(Please delete unneeded items, merge only when none are left open)

@knollengewaechs knollengewaechs marked this pull request as ready for review August 15, 2024 09:43
@knollengewaechs knollengewaechs marked this pull request as draft August 15, 2024 09:44
@knollengewaechs knollengewaechs marked this pull request as ready for review August 15, 2024 14:03
Copy link
Member

@philippotto philippotto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great! only see my one comment.

CHANGELOG.unreleased.md Show resolved Hide resolved
@knollengewaechs
Copy link
Contributor Author

there were merge conflicts in misc.e2e.js.snap so I committed the refreshed snapshots within the latest merge commit. I hope this is correct.

@knollengewaechs
Copy link
Contributor Author

knollengewaechs commented Sep 2, 2024

some screenshots :)
recommendWkorgInstance=true, isDatasetConversionEnabled=false:
image
isDatasetConversionEnabled=true:
image
other cases:
image

Copy link
Member

@philippotto philippotto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great 👍 thank you!

@knollengewaechs
Copy link
Contributor Author

I just realized that this is buggy. For me clicking the links does not work properly. I will fix this 😅

@knollengewaechs
Copy link
Contributor Author

knollengewaechs commented Sep 4, 2024

One link was relative. Next to that, clicking the links opens the file browser, as does clicking anywhere in the upload view. That doesnt feel convenient, so I will stop the event propagation on the links I think.

Sorry for the inconvenience!

@knollengewaechs knollengewaechs merged commit b49706d into master Sep 4, 2024
2 checks passed
@knollengewaechs knollengewaechs deleted the update-upload-ds-text branch September 4, 2024 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update the text in the "Upload Dataset" Screen in the Open Source version
2 participants