Improve performance of skeleton tab #7989
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichaelBuessemeyer
requested changes
Aug 14, 2024
frontend/javascripts/oxalis/view/right-border-tabs/tree_hierarchy_view.tsx
Outdated
Show resolved
Hide resolved
frontend/javascripts/oxalis/view/right-border-tabs/tree_hierarchy_view.tsx
Outdated
Show resolved
Hide resolved
frontend/javascripts/oxalis/view/right-border-tabs/tree_hierarchy_view.tsx
Show resolved
Hide resolved
frontend/javascripts/oxalis/view/right-border-tabs/tree_hierarchy_view.tsx
Outdated
Show resolved
Hide resolved
frontend/javascripts/oxalis/view/right-border-tabs/tree_hierarchy_view.tsx
Outdated
Show resolved
Hide resolved
…unctions for the context menu and hoist where possible
frontend/javascripts/oxalis/view/right-border-tabs/tree_hierarchy_view.tsx
Show resolved
Hide resolved
frontend/javascripts/oxalis/view/right-border-tabs/tree_hierarchy_view.tsx
Show resolved
Hide resolved
MichaelBuessemeyer
approved these changes
Aug 15, 2024
There was a problem hiding this comment.
Awesome works 🎉
I only noticed an unrelated thing: If there are enough skeletons so that the tab becomes vertically scrollable, the horizontal scrollbar is pushed out of the tab and is therefore not reachable anymore. => In case a skeleton has a long name, one can no longer scroll to see the full name :/
As this is unrelated lets mergy merge and some this in another pr
oh and the pref improvement is very noticeable 🎉
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR optimizes the contextmenu for tree items similarily how it was done for the segments in #7958. The scroll speed is improved by a factor of ~3.
Use "ignore whitespace" while reviewing. even better: use this tip.
URL of deployed dev instance (used for testing):
Steps to test:
Issues:
(Please delete unneeded items, merge only when none are left open)