-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Segment Anything 2 with 3D support #7965
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Backend looks good to me so far :)
frontend/javascripts/oxalis/model/sagas/quick_select_ml_saga.ts
Outdated
Show resolved
Hide resolved
@MichaelBuessemeyer I think you can already have a look at the frontend :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for all the effort to integrate SAM2. Works perfectly 🚀
During reviewing I only found minor suggestions and one confusion: One request param in the backend is annotated as "in target mag" and the frontend always seems to the bbox in mag 1.
But the feature still seems to work perfectly 🚀 -> Testing went well, I have no suggestions in that regard
frontend/javascripts/test/model/binary/find_bounding_box_in_nd.spec.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Frontend & Backend LGTM 🚀
Didn't do another round of testing as there weren't much functional change. Just ping me in case I should restest :)
URL of deployed dev instance (used for testing):
Steps to test:
ssh -L 8080:localhost:8080 euphorix
TODOs:
Issues:
(Please delete unneeded items, merge only when none are left open)