Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support reading zstd-compressed zarr2 datasets #7964

Merged
merged 3 commits into from
Aug 5, 2024
Merged

support reading zstd-compressed zarr2 datasets #7964

merged 3 commits into from
Aug 5, 2024

Conversation

fm3
Copy link
Member

@fm3 fm3 commented Jul 31, 2024

I didn’t find details about the zarr2 specification for the zstd compressor, so I’m just taking what I saw in the example dataset (just "level"). That means that for datasets with non-integer level or a different feature like checksums it may still not work. Let’s work on that when we notice problems.

URL of deployed dev instance (used for testing):

Steps to test:

  • Add a zstd-compressed remote dataset, e.g. s3://janelia-cosem-datasets/jrc_mus-nacc-4/jrc_mus-nacc-4.zarr/
  • Should load correctly (note: the contrast of that dataset is very low compared to the int16 data range)

Issues:


  • Updated changelog
  • Needs datastore update after deployment

@fm3 fm3 self-assigned this Jul 31, 2024
@fm3 fm3 marked this pull request as ready for review July 31, 2024 12:34
@fm3 fm3 requested a review from MichaelBuessemeyer July 31, 2024 12:34
Copy link
Contributor

@MichaelBuessemeyer MichaelBuessemeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aesome, works 🎉

@fm3 fm3 enabled auto-merge (squash) August 5, 2024 05:47
@fm3 fm3 merged commit ab290ec into master Aug 5, 2024
2 checks passed
@fm3 fm3 deleted the zarr2-zstd branch August 5, 2024 06:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support ZStandard Compression for Zarr (version 2)
2 participants