Add max timeout for chunks in resumable upload and misc tweaks #7932
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g progress; tweak listed supported extensions
philippotto
commented
Jul 18, 2024
| @@ -21,6 +21,7 @@ For upgrade instructions, please check the [migration guide](MIGRATIONS.released | |||
|
|
|||
| ### Fixed | |||
| - Fixed a bug that allowed the default newly created bounding box to appear outside the dataset. In case the whole bounding box would be outside it is created regardless. [#7892](https://github.com/scalableminds/webknossos/pull/7892) | |||
| - Fixed a rare bug that could cause hanging dataset uploads. [#7932](https://github.com/scalableminds/webknossos/pull/7932) | |||
There was a problem hiding this comment.
even though we are not certain that this is the fix, I still think it makes sense to mention it here. the line does not claim that it fixes all bugs that cause hanging uploads.
fm3
reviewed
Jul 18, 2024
| @@ -317,7 +317,6 @@ const getPostUploadModal = ( | |||
| <Button type="primary" onClick={() => history.push("/jobs")}> | |||
| View the Jobs Queue | |||
| </Button> | |||
| import | |||
There was a problem hiding this comment.
this was accidentally added in a58a78e#diff-b626f1738c0fb701d260efe19bdee10f7f57981f881c85a42d3588999c27db55R320 and I removed it again.
Co-authored-by: Florian M <[email protected]>
fm3
approved these changes
Jul 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
URL of deployed dev instance (used for testing):
Steps to test:
Issues:
(Please delete unneeded items, merge only when none are left open)