-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Url based remote dataset import #7844
Conversation
} catch (_e) { | ||
Toast.error( | ||
"The current datasource config contains invalid JSON. Cannot add the new Zarr/N5 data.", | ||
); | ||
return; | ||
} | ||
if (existingDatasource != null && !_.isEqual(existingDatasource.scale, newDataSource.scale)) { | ||
if ( | ||
existingDatasource?.scale != null && |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this was failing in my case because the dataSourceJson didnt contain the scale at some point. It seems to me that its still making sense, but I just want to make sure that its not problematic in another case.
- obvs check whether usual remote DS upload is still working fine
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looking good overall! left a couple of comments :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great! I didn't do a final test, since I assume you will do (or have done) this before the merge :)
Amazing, thank you! Yes, I tested it just now and it still seems to be working good. I will quickly test it again tomorrow right before merging. |
URL of deployed dev instance (used for testing):
Steps to test:
/import?url=<...>
. Ideally the dataset should open after a bit of loadingTODOs:
The explored data has a different voxel size from the datasource that was already loaded.
isNameValid
calls!handleStoreDataset
seems to only be called once...fix that brain spinner is jumping when loading DS(edit: skipped for now. I think this happens if the navbar changes from text to icons, I didnt find an easy reason and it doesnt seem worth to spend more time thereIssues:
(Please delete unneeded items, merge only when none are left open)