-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Persist mappingName and mappingIsLocked in NML #7822
Conversation
The code lgtm 🎉
This worked, but now I have a green dataset bounding box 🤔 => I created an issue for this.
I created a new annotation, added a skeleton and manipulated the volume without a mapping enabled. This locks the annotation to the state, that no mapping is selected. But when I download this annotation and reupload it, the fact that the state of "no mapping is selected" is locked is no longer present and I can simply activate a mapping. I would have thought that this would need to be persisted as well & also applied when reuploading. |
Thanks! I commented in that issue, I tend to think it’s unrelated to the mappings, but we should investigate that.
Good catch! I hadn’t considered this case. Added it now! Could you have another look? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tröt 🎉
Thanks for fixing this 🙏
URL of deployed dev instance (used for testing):
Steps to test:
Issues: