Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Persist mappingName and mappingIsLocked in NML #7822

Merged
merged 5 commits into from
May 28, 2024
Merged

Persist mappingName and mappingIsLocked in NML #7822

merged 5 commits into from
May 28, 2024

Conversation

fm3
Copy link
Member

@fm3 fm3 commented May 23, 2024

URL of deployed dev instance (used for testing):

Steps to test:

  • Create annotation on dataset with agglomerate mapping, brush some (mapping will be locked)
  • download + reupload
  • Mapping of fallback layer should still be selected and locked
  • Also test download+reupload with mapping but without volume brushing (mapping should be set but not locked)
  • Also test without mapping (download+reupload should still run through without error)
  • Beware of unrelated bug Volume saving with Fallback Layer with Segment Index File fails #7823 – if your test dataset has a segment index file, you might have to remove that before you can test this PR

Issues:


@fm3 fm3 self-assigned this May 23, 2024
@fm3 fm3 changed the title WIP: Persist mappingName and mappingIsLocked in NML Persist mappingName and mappingIsLocked in NML May 23, 2024
@fm3 fm3 marked this pull request as ready for review May 23, 2024 12:29
@fm3 fm3 requested a review from MichaelBuessemeyer May 23, 2024 12:30
@MichaelBuessemeyer
Copy link
Contributor

MichaelBuessemeyer commented May 24, 2024

The code lgtm 🎉

Create annotation on dataset with agglomerate mapping, brush some (mapping will be locked)
download + reupload
Mapping of fallback layer should still be selected and locked

This worked, but now I have a green dataset bounding box 🤔 => I created an issue for this.
image

Also test without mapping (download+reupload should still run through without error)

I created a new annotation, added a skeleton and manipulated the volume without a mapping enabled. This locks the annotation to the state, that no mapping is selected. But when I download this annotation and reupload it, the fact that the state of "no mapping is selected" is locked is no longer present and I can simply activate a mapping. I would have thought that this would need to be persisted as well & also applied when reuploading.

@fm3
Copy link
Member Author

fm3 commented May 27, 2024

This worked, but now I have a green dataset bounding box 🤔 => I created an #7831 for this.

Thanks! I commented in that issue, I tend to think it’s unrelated to the mappings, but we should investigate that.

manipulated the volume without a mapping enabled. This locks the annotation to the state, that no mapping is selected

Good catch! I hadn’t considered this case. Added it now! Could you have another look?

Copy link
Contributor

@MichaelBuessemeyer MichaelBuessemeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tröt 🎉

Thanks for fixing this 🙏

@fm3 fm3 merged commit 2a4cac7 into master May 28, 2024
2 checks passed
@fm3 fm3 deleted the mapping-nml branch May 28, 2024 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Persist mappingName in NML, respect on reupload
2 participants