-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Explore remote datasets in datastore #7800
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this PR.
I took a look at the backend changes as best as I could. I only found minor suggestions in the frontend code. Once they are fixed, this should be good to go :)
The testing worked fine 🎉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The exploring of remote and local datasets now happens entirely in the datastore module. The wk side only forwards the request (after storing the credentials in postgres and then sending only the credential IDs).
This means that the user can select which datastore should handle the exploring.
It also means that for local datasets, the directory whitelist config setting does not have to work on the wk server side, only on the datastore side. Thus, this feature is now also available for multi-datastore setups where the wk side does not have access to the same file systems.
TODO
/datasets/exploreRemote
parameters (needs to be equal for all items in the list)Steps to test:
file://
, should yield error message suggesting you add the directory to the config settingIssues: