-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix deprecation warnings for antd <Collapse> components #7610
Conversation
…-collapse-deprecation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good and testing went well mostly. I had one crash when opening the dataset settings page, though:
https://fixcollapsedeprecation.webknossos.xyz/datasets/sample_organization/2017-05-31_mSEM_scMS109_bk_100um_v01-aniso/edit
Well spotted. I pushed a fix that should resolve this crash. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💯
Fix deprecation warnings for antd
<Collapse>
components. API changed toitems
props instead of React children/<Panel>
.See https://ant.design/components/collapse#collapsepanel
URL of deployed dev instance (used for testing):
Steps to test:
<Collapse />
TODOs:
Issues:
(Please delete unneeded items, merge only when none are left open)