Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect logic when deciding whether to use segment stats for adhoc meshing #7600

Merged
merged 2 commits into from
Jan 31, 2024
Merged

Fix incorrect logic when deciding whether to use segment stats for adhoc meshing #7600

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f079747
fix incorrect logic when deciding whether to use segment stats for ad…
philippotto Jan 31, 2024
2fe95c3
update changelog
philippotto Jan 31, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.unreleased.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ For upgrade instructions, please check the [migration guide](MIGRATIONS.released
- Fixed rare SIGBUS crashes of the datastore module that were caused by memory mapping on unstable file systems. [#7528](https://github.com/scalableminds/webknossos/pull/7528)
- Fixed loading local datasets for organizations that have spaces in their names. [#7593](https://github.com/scalableminds/webknossos/pull/7593)
- Fixed a bug where proofreading annotations would stay black until the next server restart due to expired but cached tokens. [#7598](https://github.com/scalableminds/webknossos/pull/7598)
- Fixed a bug where ad-hoc meshing didn't make use of a segment index, even when it existed. [#7600](https://github.com/scalableminds/webknossos/pull/7600)

### Removed

Expand Down
2 changes: 1 addition & 1 deletion frontend/javascripts/oxalis/model/sagas/mesh_saga.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -352,7 +352,7 @@ function* loadFullAdHocMesh(
volumeTracing?.hasSegmentIndex &&
!volumeTracing.mappingIsEditable &&
visibleSegmentationLayer?.tracingId != null &&
additionalCoordinates == null; // TODO remove in https://github.com/scalableminds/webknossos/pull/7411
(additionalCoordinates == null || additionalCoordinates.length === 0); // TODO remove in https://github.com/scalableminds/webknossos/pull/7411
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dieknolle3333 I know that your other PR will fix this, too, but this small change should go a bit quicker into the master, I think. It will likely cause a small merge conflict on your end. Just as a heads-up..

let positionsToRequest = usePositionsFromSegmentStats
? yield* getChunkPositionsFromSegmentStats(
tracingStoreHost,
Expand Down