Fix ad-hoc meshing with agglomerates and cumsum.json #7449
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ad-Hoc meshing can request data from bboxes that are not aligned with buckets, and thus also not aligned with the segmentation chunks described in the cumsum.json.
This lead to an edge case where the cumsum-json-based agglomerate mapping had to gather the correct segmentation chunks that the requested bbox intersects. This is supported, but there was a bug in that logic, which is now fixed in this PR. The currDimensions used to advance to the next chunk bbox in each dimension has to be reset before each inner loop starts, so that the correct topleft for the next box can be found. Thanks to @daniel-wer and @philippotto for the debugging help :)
Other small cleanups:
.toLong
on things that are already LongSteps to test: