Fix segment stats for layers without segment index

CHANGELOG.released.md

@@ -457,6 +457,7 @@ For upgrade instructions, please check the [migration guide](MIGRATIONS.released
 - Fixed broken creation of tasks using base NMLs. [#6634](https://github.com/scalableminds/webknossos/pull/6634)
 - Fixed that the precomputation of meshes didn't take the active mapping into account. [#6651](https://github.com/scalableminds/webknossos/pull/6651)
 - Fixed false-positive warning about an outdated annotation version. [#6656](https://github.com/scalableminds/webknossos/pull/6656)
+- Fixed that segment statistics seemed to be available but broken for segments without index. [#7377](https://github.com/scalableminds/webknossos/pull/7377)
 
 ## [22.11.2](https://github.com/scalableminds/webknossos/releases/tag/22.11.2) - 2022-11-10
 [Commits](https://github.com/scalableminds/webknossos/compare/22.11.1...22.11.2)

frontend/javascripts/oxalis/view/context_menu.tsx

@@ -1105,17 +1105,23 @@ function ContextMenuInner(propsWithInputRef: Props) {
     datasetScale,
     globalPosition,
     maybeViewport,
+    visibleSegmentationLayer,
+    volumeTracing,
   } = props;
 
   const segmentIdAtPosition = globalPosition != null ? getSegmentIdForPosition(globalPosition) : 0;
-  const { visibleSegmentationLayer, volumeTracing } = props;
   const hasNoFallbackLayer =
     visibleSegmentationLayer != null &&
     "fallbackLayer" in visibleSegmentationLayer &&
     visibleSegmentationLayer.fallbackLayer == null;
   const [segmentVolume, boundingBoxInfo] = useFetch(
     async () => {
-      if (contextMenuPosition == null || volumeTracing == null || !hasNoFallbackLayer) {
+      if (
+        contextMenuPosition == null ||
+        volumeTracing == null ||
+        !hasNoFallbackLayer ||
+        !volumeTracing.hasSegmentIndex
+      ) {
         return [];
       } else {
         const tracingId = volumeTracing.tracingId;
@@ -1158,6 +1164,12 @@ function ContextMenuInner(propsWithInputRef: Props) {
     return <></>;
   }
 
+  // Currently either segmentIdAtPosition or maybeClickedMeshId is set, but not both.
+  // segmentIdAtPosition is only set if a segment is hovered in one of the xy, xz, or yz viewports.
+  // maybeClickedMeshId is only set, when a mesh is hovered in the 3d viewport.
+  // Thus the segment id is always unambiguous / clearly defined.
+  const isHoveredSegmentOrMesh = segmentIdAtPosition > 0 || maybeClickedMeshId != null;
+
   const activeTreeId = skeletonTracing != null ? skeletonTracing.activeTreeId : null;
   const activeNodeId = skeletonTracing?.activeNodeId;
 
@@ -1246,7 +1258,7 @@ function ContextMenuInner(propsWithInputRef: Props) {
     </Tooltip>
   );
 
-  if (hasNoFallbackLayer) {
+  if (hasNoFallbackLayer && volumeTracing?.hasSegmentIndex && isHoveredSegmentOrMesh) {
     infoRows.push(
       getInfoMenuItem(
         "volumeInfo",
@@ -1260,7 +1272,7 @@ function ContextMenuInner(propsWithInputRef: Props) {
     );
   }
 
-  if (hasNoFallbackLayer) {
+  if (hasNoFallbackLayer && volumeTracing?.hasSegmentIndex && isHoveredSegmentOrMesh) {
     infoRows.push(
       getInfoMenuItem(
         "boundingBoxPositionInfo",
@@ -1292,11 +1304,7 @@ function ContextMenuInner(propsWithInputRef: Props) {
     );
   }
 
-  // Currently either segmentIdAtPosition or maybeClickedMeshId is set, but not both.
-  // segmentIdAtPosition is only set if a segment is hovered in one of the xy, xz, or yz viewports.
-  // maybeClickedMeshId is only set, when a mesh is hovered in the 3d viewport.
-  // Thus the segment id is always unambiguous / clearly defined.
-  if (segmentIdAtPosition > 0 || maybeClickedMeshId != null) {
+  if (isHoveredSegmentOrMesh) {
     const segmentId = maybeClickedMeshId ? maybeClickedMeshId : segmentIdAtPosition;
     infoRows.push(
       getInfoMenuItem(

frontend/javascripts/oxalis/view/right-border-tabs/segments_tab/segments_view.tsx

@@ -84,6 +84,7 @@ import type {
   Segment,
   SegmentGroup,
   SegmentMap,
+  VolumeTracing,
 } from "oxalis/store";
 import Store from "oxalis/store";
 import DomVisibilityObserver from "oxalis/view/components/dom_visibility_observer";
@@ -136,6 +137,7 @@ type StateProps = {
   segments: SegmentMap | null | undefined;
   segmentGroups: Array<SegmentGroup>;
   visibleSegmentationLayer: APISegmentationLayer | null | undefined;
+  activeVolumeTracing: VolumeTracing | null | undefined;
   allowUpdate: boolean;
   organization: string;
   datasetName: string;
@@ -177,6 +179,7 @@ const mapStateToProps = (state: OxalisState): StateProps => {
     segments,
     segmentGroups,
     visibleSegmentationLayer,
+    activeVolumeTracing,
     allowUpdate:
       state.tracing.restrictions.allowUpdate && !isVisibleButUneditableSegmentationLayerActive,
     organization: state.dataset.owningOrganization,
@@ -1061,7 +1064,8 @@ class SegmentsView extends React.Component<Props, State> {
     if (
       visibleSegmentationLayer == null ||
       !("fallbackLayer" in visibleSegmentationLayer) ||
-      visibleSegmentationLayer.fallbackLayer != null
+      visibleSegmentationLayer.fallbackLayer != null ||
+      !this.props.activeVolumeTracing?.hasSegmentIndex
     ) {
       //in this case there is a fallback layer
       return null;
@@ -1501,8 +1505,7 @@ class SegmentsView extends React.Component<Props, State> {
       segments.length > 0
     ) {
       const state = Store.getState();
-      const volumeTracing = getActiveSegmentationTracing(state);
-      const tracingId = volumeTracing?.tracingId;
+      const tracingId = this.props.activeVolumeTracing?.tracingId;
       if (tracingId == null) return null;
       const tracingStoreUrl = state.tracing.tracingStore.url;
       return this.state.activeStatisticsModalGroupId === groupId ? (

frontend/stylesheets/dark.less

@@ -55,6 +55,7 @@ a:hover {
 
 .cell-context-icon {
   background-image: url("/assets/images/cell-bright.svg");
+  opacity: 0.5;
 }
 
 .hide-tree-edges-icon {

frontend/stylesheets/trace_view/_tracing_view.less

@@ -563,6 +563,7 @@ img.keyboard-mouse-icon:first-child {
   display: inline-block;
   background-image: url("/assets/images/cell.svg");
   background-size: contain;
+  opacity: 0.65;
 }
 
 .hide-tree-edges-icon {